little bug report V5

vanzi

Member
YetiShare User
YetiShare Supporter
Oct 19, 2019
41
8
8
Hi Adam, i send a small bug report after a week of use:

a small premise concerns the fact that this version is much faster than the previous version 4. what I report in this list has also been reported elsewhere, but in order not to disperse the information among the various posts and tickets, I collect it in a single post.


1) account label: if I create new types of user packages, the label of "free user" is always shown and not the name of the new package. in version 4 it worked correctly.


2) total file downloads/views are not shown in the user's file list.


3) The video player does not allow vast or alternative forms of advertising in preroll or other form


4) I found the possibility to insert the javascript code of the popunder are in the configuration page of the download pages. there is no possibility of insertion in the head of the site but only in the footer. it is not possible to insert ads in videos on embed or direct link pages.


5) it is necessary to insert a system for sending service emails to users and implement sending the file removal email also to the owner of the file


6) cron job app/tasks/delete_redundant_files.cron.php report this:
Code:
<p style='border:5px solid red;background-color:#fff;padding:12px;font-family: verdana, sans-serif;'>
<strong>Database Error:</strong><br/>PDOException: SQLSTATE[21000]: Cardinality violation: 1242
Subquery returns more than 1 row in /var/www/vhosts/xxxxxxx.zzzz/httpdocs/app/core/Database.class.php:141
Stack trace: #0 /var/www/vhosts/xxxxxxx.zzzz/httpdocs/app/core/Database.class.php(141): PDOStatement->execute(Array) #1
/var/www/vhosts/xxxxxxx.zzzz/httpdocs/app/core/Database.class.php(301):...
and in admin page : https://gyazo.com/e2081c6614de30bdfacdfa9603a50541

For now I have not found other important things. congratulations again Adam and your staff for this new version, definitely improved in performance and in some features.


Regards
 

vanzi

Member
YetiShare User
YetiShare Supporter
Oct 19, 2019
41
8
8
it happened to me a few times that for a strange reason, it was the password automatically and I didn't notice it. it is possible to add in the list view a column with the flag password / no password both visually and the possibility to remove or insert it directly from the flag?

regards
 

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
Thanks for reporting :) I'll get to this later this week.
 
  • Like
Reactions: vanzi

vanzi

Member
YetiShare User
YetiShare Supporter
Oct 19, 2019
41
8
8
xsendfile not work in v5. the video player doesn't work and opens the download window directly.
 

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
I'm working over these now. Expect an update today.
 
  • Like
Reactions: vanzi

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
1) account label: if I create new types of user packages, the label of "free user" is always shown and not the name of the new package. in version 4 it worked correctly
In:

"\themes\spirit\views\account\partial\layout_logged_in.html.twig"

Replace:

UserHelper.getLevelLabel(Auth.level_id)

with:

UserHelper.getLevelLabel(Auth.package_id)

There'll be 2 entries. All changes will be in the next release due soon.
 
  • Like
Reactions: vanzi

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
2) total file downloads/views are not shown in the user's file list.
Done in the code for the next release. There's a few files to update so probably best waiting for the release on this one.
 
  • Like
Reactions: vanzi

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
4) I found the possibility to insert the javascript code of the popunder are in the configuration page of the download pages. there is no possibility of insertion in the head of the site but only in the footer. it is not possible to insert ads in videos on embed or direct link pages.
Do you ads specifically require/not work in the footer? I can add a new admin option for inserting into the head if needed.
 
  • Like
Reactions: vanzi

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
5) it is necessary to insert a system for sending service emails to users and implement sending the file removal email also to the owner of the file
Logged for review for the next release.
 
  • Like
Reactions: vanzi

vanzi

Member
YetiShare User
YetiShare Supporter
Oct 19, 2019
41
8
8
Do you ads specifically require/not work in the footer? I can add a new admin option for inserting into the head if needed.
Yes, it works. but only on the home page and in the standard pages of the site. it does not work in embed and direct link
and in the pages where the footer is not present
 

vanzi

Member
YetiShare User
YetiShare Supporter
Oct 19, 2019
41
8
8
the social plugin does not work. all logins fail
 

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
the social plugin does not work. all logins fail
The only issue I've found is when logging in from a temp account, there's a fix for this in the release due soon. Otherwise please detail the steps to replicate.
 

vanzi

Member
YetiShare User
YetiShare Supporter
Oct 19, 2019
41
8
8
The only issue I've found is when logging in from a temp account, there's a fix for this in the release due soon. Otherwise please detail the steps to replicate.
SYSTEM ERROR:

Error Msg:Uncaught Error: Call to a member function has() on null in /var/www/vhosts/xxxxxx/httpdocs/plugins/sociallogin/controllers/SocialloginController.class.php:122 Stack trace: #0 /var/www/vhosts/xxxxxx/httpdocs/plugins/sociallogin/controllers/SocialloginController.class.php(47): Plugins\Sociallogin\Controllers\SocialloginController->processUserLogin(Object(Hybridauth\Provider\Facebook), 'Facebook') #1 [internal function]: Plugins\Sociallogin\Controllers\SocialloginController->login('Facebook') #2 /var/www/vhosts/xxxxxx/httpdocs/app/helpers/RouteHelper.class.php(369): call_user_func_array(Array, Array) #3 /var/www/vhosts/xxxxxxx/httpdocs/app/core/Framework.class.php(246): App\Helpers\RouteHelper::processRoutes() #4 /var/www/vhosts/xxxxxx/httpdocs/app/core/Framework.class.php(23): App\Core\Framework::dispatch() #5 /var/www/vhosts/xxxxxx/httpdocs/index.php(20): App\Core\Framework::run() #6 {main} thrown
File:/var/www/vhosts/xxxxxx/httpdocs/plugins/sociallogin/controllers/SocialloginController.class.php
Line Number:122
Error Type:E_ERROR


this is for all social login
 

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
Yes that's the same issue. Next release will resolve it, hopefully be out in a few days.
 
  • Like
Reactions: vanzi

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
Just to be clear, it happens when you login as a temp user, then try to upgrade to a full account via social login. Because you have the temp account cookie, it runs this process which fails. If you were to clear your browser cookies, then try a social login it would work. The fix in a few days will resolve this issue though.
 
  • Like
Reactions: vanzi

vanzi

Member
YetiShare User
YetiShare Supporter
Oct 19, 2019
41
8
8
Hi Adam, I would like to point out that the service emails are not working properly. when I create a new email and try to save the draft, it tells me that it cannot save the newsletter and the same thing when I try to send it to both users and the test email.

"Error
There was a problem adding the newsletter, please try again"
 

adam

Administrator
Staff member
Dec 5, 2009
1,901
72
48
Hi Adam, I would like to point out that the service emails are not working properly. when I create a new email and try to save the draft, it tells me that it cannot save the newsletter and the same thing when I try to send it to both users and the test email.

"Error
There was a problem adding the newsletter, please try again"
Can you try executing the DB patch below? It's included in the newsletter plugin code for that release, but not the core SQL patches (as it would cause issues with installs that didn't have the newsletter plugin installed).

UPDATE plugin_newsletter SET date_sent = '2038-01-01 00:00:00' WHERE CAST(date_sent AS CHAR(20)) = '0000-00-00 00:00:00';
ALTER TABLE `plugin_newsletter` CHANGE `date_sent` `date_sent` datetime NULL AFTER `date_created`;
UPDATE plugin_newsletter SET date_sent = NULL WHERE date_sent = '2038-01-01 00:00:00';
ALTER TABLE `plugin_newsletter` ADD `form_type` int(1) NOT NULL DEFAULT '1' AFTER `html_content`;


It would also be applied by uninstalling/installing the plugin, although you may loose some plugin data doing it that way.
 
  • Like
Reactions: vanzi